Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic beginning of authentication module. #1084

Merged
merged 1 commit into from
Aug 25, 2015
Merged

Basic beginning of authentication module. #1084

merged 1 commit into from
Aug 25, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 25, 2015

@jgeewax This is the simple start I mentioned to get #805 and #830 in slowly but surely.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2015
@jgeewax
Copy link
Contributor

jgeewax commented Aug 25, 2015

LGTM 👍

But -- shouldn't this live in gcloud-common somehow? /cc @stephenplusplus @callmehiphop

@dhermes
Copy link
Contributor Author

dhermes commented Aug 25, 2015

I filed an issue there so we can follow up.

dhermes added a commit that referenced this pull request Aug 25, 2015
@dhermes
Merge pull request #1084 from dhermes/add-simple-auth-doc
ac13419 
Basic beginning of authentication module.
@dhermes dhermes merged commit ac13419 into googleapis:master Aug 25, 2015
@dhermes dhermes deleted the add-simple-auth-doc branch August 25, 2015 16:55
@dhermes dhermes mentioned this pull request Sep 30, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auth cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @jgeewax @googlebot